Skip to content

Conversation

@lasselehtinen
Copy link
Contributor

We have some old eBooks where the dc:subject might be empty. This produces an TypeError when trying to parse getEpubVersionNumber from such ePub. I have added an array filter that removes empty values and arrays from the values and added tests.

@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.07%. Comparing base (e5d45ae) to head (197f468).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #118   +/-   ##
=========================================
  Coverage     90.07%   90.07%           
  Complexity      843      843           
=========================================
  Files            32       32           
  Lines          2589     2589           
=========================================
  Hits           2332     2332           
  Misses          257      257           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ewilan-riviere
Copy link
Contributor

Thanks you!

@ewilan-riviere ewilan-riviere merged commit a11180b into kiwilan:main Aug 11, 2025
10 checks passed
@lasselehtinen
Copy link
Contributor Author

Thanks for accepting the PR. Any estimates when you would you create a new release?

@ewilan-riviere
Copy link
Contributor

Today or tomorrow, sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants