Kiwix Desktop should be called "Kiwix" for end-users - #1302
Open
kelson42 wants to merge 4 commits into
Open
Conversation
kelson42
force-pushed
the
binary-called-kiwix
branch
from
December 24, 2024 09:28
f014f8e to
40d0632
Compare
kelson42
changed the title
kiwix-desktop to kiwix
Closed
kelson42
force-pushed
the
binary-called-kiwix
branch
from
December 26, 2024 21:39
812243a to
9f3bd13
Compare
kelson42
force-pushed
the
binary-called-kiwix
branch
from
January 5, 2025 01:29
9eef5e9 to
0b83943
Compare
veloman-yunkan
left a comment
veloman-yunkan
left a comment
Collaborator
There was a problem hiding this comment.
This will also require respective changes in kiwix-build. I think that a draft version of that PR should be prepared before we merge this one.
| "error-title":"Error", | ||
| "error-downloader-window-title":"Cannot create downloader", | ||
| "error-downloader-launch-message":"Impossible to launch downloader, Kiwix-desktop will start but all download functions will not working!", | ||
| "error-downloader-launch-message":"Impossible to launch downloader, Kiwix will start but all download functions will not working!", |
Collaborator
There was a problem hiding this comment.
Please also fix the grammar in this message. It should rather read
"Impossible to launch the downloader, Kiwix will start but download functionality will not work!"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1243