Fix: added time left to complete download in library - #1344
Open
i-am-space wants to merge 1 commit into
Open
Conversation
kelson42
force-pushed
the
clean-fix-issue-1328
branch
from
March 12, 2025 07:32
dadc243 to
ec488ff
Compare
Collaborator
|
@i-am-space Thank you for your PR, we will review it. |
kelson42
force-pushed
the
clean-fix-issue-1328
branch
2 times, most recently
from
December 8, 2025 08:56
62502be to
deb6d61
Compare
kelson42
requested changes
Dec 8, 2025
Collaborator
There was a problem hiding this comment.
@i-am-space Sorry again for the very late review of this PR. The feature seems to me to work as expected, but I see two things to be fixed:
- Adding at the bottom the time left makes the whole block not been centered vertically properly. See
- We have to display something like "10 s.", This should have a hint which says "10 s. left" where the "left" should be translatable. Don't forget the
qqqlanguage for the explanation.
@i-am-space Be careful, I have rebased your PR to get the latest version of our codebase with your commit on the top of it.
kelson42
force-pushed
the
clean-fix-issue-1328
branch
from
December 9, 2025 06:49
deb6d61 to
9b37054
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1328
Closed an old pull request that fixed two problems by accident.
Added a feature to count down time till download completion.