Fix sgpd entry boundaries and v3 encoding invariants - #202
Draft
kixelated wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #190.
What changed
description_length, preserving boundaries between multiple entries.sgpdencoding instead of emitting a malformed box.Root cause and impact
Unknown grouping types previously decoded the entire remaining box payload into the first entry, corrupting the parsed entry structure. Separately, setting
essentialwithout v3 defaults selected version 3 but omitted required fields, producing bytes the decoder could not read back.Validation
just checkjust test(238 tests passed)git diff --check