Fix ES descriptor and AudioSpecificConfig parsing - #205
Draft
kixelated wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Descriptor lengths were emitted least-significant group first, while decoding expected most-significant group first. AudioSpecificConfig fields that cross byte boundaries were extracted with byte-local masks and shifts, and optional ES descriptor fields were ignored without advancing over their payloads.
Impact
Descriptors with bodies of at least 128 bytes, zero-length unknown descriptors, extended AAC profiles, explicit sample rates, or optional ES descriptor flags now encode and decode without corrupting or desynchronizing the stream.
Validation
cargo test --all-targets— 242 passedjust check— all-feature check, strict Clippy, formatting, and dependency analysis passedgit diff --checkCloses #192