Preserve QuickTime v2 audio sample entries - #213
Draft
kixelated wants to merge 1 commit into
Draft
Conversation
Owner
Author
|
IDK if I care enough about QuickTime? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
f64and channel counts asu32, while validating the narrower version 0/1 encoding limitsRoot cause
Version 2 entries put placeholder values in the legacy prefix (
3channels and1 Hz). The decoder read the authoritativef64sample rate andu32channel count from the version 2 extension but discarded them. Encoding then always emitted a version 0 entry, so decoded version 2 audio could be re-encoded with the placeholders as real values.Impact
High-rate and QuickTime PCM audio now reports its actual rate and channel count, including rates above 65535 Hz, and round-trips without losing the version 2 layout.
Validation
cargo test --all-targets --all-featurescargo clippy --all-targets --all-features -- -D warningscargo fmt --all -- --checkgit diff --checkCloses #195