Return errors for missing infe content types - #218
Draft
kixelated wants to merge 1 commit into
Draft
Conversation
bradh
reviewed
Jul 31, 2026
| .as_str() | ||
| .encode(buf)?; | ||
| let content_type = self.content_type.as_deref().ok_or(Error::MissingContent( | ||
| "content_type required for infe version 0", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "content_type required for infe version 0", | |
| "content_type required for infe version 0 or 1", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #199. Refs #179.
What changed
Error::MissingContentwhen encoding a version 0infeentry without its required content type.mimeentries without a content type.Why
These required fields were unwrapped during encoding, so invalid caller-provided state could panic instead of returning a normal error.
Impact
Encoding malformed
infeentries now fails predictably without changing valid output.Validation
cargo fmt --all -- --checkcargo test --all-features(252 unit tests and 3 doctests passed)cargo clippy --all-targets --all-features -- -D warningsgit diff --check main...HEAD