Skip to content
This repository was archived by the owner on Nov 2, 2020. It is now read-only.

[WIP] feat(extension): i18n support #35

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[WIP] feat(extension): i18n support #35

wants to merge 4 commits into from

Conversation

kiyui
Copy link
Owner

@kiyui kiyui commented Jan 9, 2019

This should address the concerns in #34.

Changes:

  • Did some code refactor such that all strings are centralized
  • Added a .pot file with all the strings
  • Add some languages for testing and initial release
  • Add build script so .mo files do not need to be included (add to package.json or introduce meson)

Contributing:
Where $lang is a language such as en_US, do the following in the extension directory:

  • mkdir -p locale/$lang/LC_MESSAGES
  • msginit -i night-light-slider.pot -o locale/$lang/LC_MESSAGES/night-light-slider.po
  • Modify locale/$lang/LC_MESSAGES/night-light-slider.po with your locale
  • msgfmt locale/$lang/LC_MESSAGES/night-light-slider.po -o locale/$lang/LC_MESSAGES/night-light-slider.mo
  • Submit a PR without the compiled .mo files

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant