Skip to content

fix: nft precision tx list#602

Merged
samufacanha2 merged 1 commit intodevelopfrom
fix/nft-precision-tx-list
Mar 9, 2026
Merged

fix: nft precision tx list#602
samufacanha2 merged 1 commit intodevelopfrom
fix/nft-precision-tx-list

Conversation

@samufacanha2
Copy link
Contributor

@samufacanha2 samufacanha2 commented Mar 9, 2026

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Fixed asset precision lookup in transactions to correctly parse asset identifiers using the base segment, improving accuracy for complex asset references.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 9, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0c364cd0-78ad-4bfc-9440-5235680a42fc

📥 Commits

Reviewing files that changed from the base of the PR and between bf05ad2 and f25df49.

📒 Files selected for processing (1)
  • src/pages/transactions/index.tsx

Disabled knowledge base sources:

  • Jira integration is disabled

You can enable these sources in your CodeRabbit configuration.


Walkthrough

A single function modification in the transaction pages component adjusts how asset precision is looked up by using the asset ID prefix before a forward slash instead of the full identifier string.

Changes

Cohort / File(s) Summary
Asset Precision Lookup
src/pages/transactions/index.tsx
Modified getTransactionPrecision function to extract and use the asset ID prefix (segment before '/') as the key for looking up asset precision values, rather than the complete asset ID string.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A dash becomes a guide so true,
The slash reveals what we pursue,
Asset precision, neat and trim,
Before the stroke, the lookup wins! ✨

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/nft-precision-tx-list

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@samufacanha2 samufacanha2 merged commit e7200bc into develop Mar 9, 2026
2 of 3 checks passed
@samufacanha2 samufacanha2 deleted the fix/nft-precision-tx-list branch March 9, 2026 15:08
@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.46%. Comparing base (bf05ad2) to head (f25df49).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/pages/transactions/index.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #602      +/-   ##
==========================================
- Coverage     0.46%   0.46%   -0.01%     
==========================================
  Files          530     530              
  Lines        20951   20952       +1     
  Branches      4982    5286     +304     
==========================================
  Hits            97      97              
+ Misses       20854   20043     -811     
- Partials         0     812     +812     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

samufacanha2 added a commit that referenced this pull request Mar 9, 2026
* Merge pull request #593 from klever-io/chore/remove-sc-24h-txs

chore: remove sc 24h txs

* Merge pull request #602 from klever-io/fix/nft-precision-tx-list

fix: nft precision tx list

* fix: blocks page stale auto-update, timer drift, and Promise anti-pattern (#601)

* fix: blocks page stale auto-update, timer drift, and Promise anti-pattern

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: address review findings - consistent error handling, proper type separation

- Fix yesterdayStatisticsCall and totalStatisticsCall to throw on error
  instead of silently returning error string as IBlockStats (was causing
  silent display of zeros on API failures)
- Normalize error messages with typeof guard for non-string errors
- Revert dataUpdatedAt from shared ICard type to local CardContentProps
- Track both queries' dataUpdatedAt using Math.min for accurate staleness
- Remove silent Date.now() fallback, show empty string before first fetch

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: prevent rendering bare " ago" before data loads

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: David Ianakiara <david@klever.io>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants