Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving single line commit replacement & regex for function replacement. #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

toxicphreAK
Copy link

I tried to use the tool on adPEAS but got stuck on those two parts of the script. So I tried to fix those parts.

Improving single line commit replacement & regex for function replacement.

It now works with this example, having to test more scripts.

Copy link
Owner

@klezVirus klezVirus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, the regex \w already includes the character _. No need to explicitly add it. This commit is accepted.

@n3rada
Copy link

n3rada commented Jul 18, 2023

Why it was never merged? Does this project still maintained?

@klezVirus
Copy link
Owner

Why it was never merged? Does this project still maintained?

It is maintained, I've never accepted the PR cause I was waiting for an explaination by the author of the PR.

@toxicphreAK
Copy link
Author

What are you awaiting to explain from my side? I just improved regex and you got the point...

@klezVirus
Copy link
Owner

Hi @toxicphreAK. So if this regex is an improvement I need to understand why. By now, I sincerely cannot accept it, cause this regex is discarding all comments with a single or double quote in them, for no logic reason.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants