This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Update Golang in go.mod to 1.21 #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
approved
knative-prow
bot
requested review from
Cali0707,
Leo6Leo,
matzew and
pierDipi
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1461 +/- ##
=======================================
Coverage 68.39% 68.39%
=======================================
Files 39 39
Lines 2370 2370
=======================================
Hits 1621 1621
Misses 670 670
Partials 79 79 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
merged commit d536a21
into
knative-extensions:main
18 of 19 checks passed
matzew
reviewed
Jan 23, 2024
| @@ -1,6 +1,6 @@ | |||
| module knative.dev/eventing-kafka | |||
|
|
|||
| go 1.19 | |||
| go 1.21 | |||
There was a problem hiding this comment.
mine 1462, also adds toolchain go1.21.4 ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing issues in #1460. Updating golang in go.mod helped in other cases