Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding some signal handling #27

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Adding some signal handling #27

merged 1 commit into from
Jan 7, 2025

Conversation

matzew
Copy link
Contributor

@matzew matzew commented Jan 6, 2025

Changes

  • Adding some signal handling

@matzew
Adding some signal handling
fe4a113 
Signed-off-by: Matthias Wessendorf <[email protected]>
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2025
@knative-prow knative-prow bot requested review from lance and lkingland January 6, 2025 13:17
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 6, 2025
lkingland
lkingland approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@lkingland lkingland left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking up how to register for, and handle, events. Looks like the on_stop lifecycle event feature is now available.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lkingland lkingland removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2025
@knative-prow knative-prow bot merged commit 7b71049 into knative-extensions:main Jan 7, 2025
14 checks passed
@matzew matzew changed the title WIP: Adding some signal handling Adding some signal handling Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkingland lkingland lkingland approved these changes

@lance lance Awaiting requested review from lance

Assignees

@lkingland lkingland

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matzew @lkingland