Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding on_stop lifecycle handler #28

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Adding on_stop lifecycle handler #28

merged 1 commit into from
Jan 9, 2025

Conversation

matzew
Copy link
Contributor

@matzew matzew commented Jan 8, 2025

Changes

  • 🧹 Update main.py to leverage the on_stop lifecycle event

/kind

Fixes #

Release Note

Docs

@matzew
Adding on_stop lifecycle handler
def24c8 
Signed-off-by: Matthias Wessendorf <[email protected]>
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 8, 2025

@matzew: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • 🧹 Update main.py to leverage the on_stop lifecycle event

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot requested review from lkingland and salaboy January 8, 2025 08:21
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 8, 2025
lkingland
lkingland approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes. Good to have this at least log in the example app.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 6ab13a1 into knative-extensions:main Jan 9, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkingland lkingland lkingland approved these changes

@salaboy salaboy Awaiting requested review from salaboy

Assignees

@lkingland lkingland

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matzew @lkingland