Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💝 Migrating to sink flag for --to param #368

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Sep 20, 2024

Changes

  • 💝 Migrating to sink flag for --to param
  • 🧹 Removing the --sender-namespace (the --namespace takes over)
  • 🧹 Better logging, common with kn

/kind enhancement

Relations

Fixes #282
Fixes #202
Fixes #356
Fixes #160
Requires knative/client#1968

Release Notes

Target for the sending is now done excusivly with --to param, which follows the standard for Kn sink format.
The kubernetes related parameters have been aligned to be on par with Kn.

Docs

TBD

Copy link

knative-prow bot commented Sep 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement labels Sep 20, 2024
@knative-prow knative-prow bot requested review from dsimansk and rhuss September 20, 2024 13:40
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 20, 2024
@cardil cardil force-pushed the feature/sink branch 4 times, most recently from 559b1ca to b081612 Compare September 23, 2024 17:50
@cardil
Copy link
Contributor Author

cardil commented Sep 23, 2024

/test all

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 79.70149% with 68 lines in your changes missing coverage. Please review.

Project coverage is 69.26%. Comparing base (f9cb9aa) to head (da9f541).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/k8s/params.go 0.00% 17 Missing ⚠️
pkg/cli/target.go 56.25% 13 Missing and 1 partial ⚠️
internal/cli/send.go 72.22% 7 Missing and 3 partials ⚠️
pkg/k8s/addressresolver.go 76.19% 4 Missing and 1 partial ⚠️
pkg/k8s/kubeclient.go 82.14% 3 Missing and 2 partials ⚠️
pkg/sender/binding.go 78.26% 3 Missing and 2 partials ⚠️
internal/cli/root.go 95.12% 1 Missing and 1 partial ⚠️
pkg/binding/memoized.go 81.81% 1 Missing and 1 partial ⚠️
pkg/k8s/test/addressresolver_cases.go 88.88% 1 Missing and 1 partial ⚠️
pkg/sender/in_cluster.go 75.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #368       +/-   ##
===========================================
+ Coverage   55.67%   69.26%   +13.58%     
===========================================
  Files          51       48        -3     
  Lines        1374     1246      -128     
===========================================
+ Hits          765      863       +98     
+ Misses        540      313      -227     
- Partials       69       70        +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cardil
Copy link
Contributor Author

cardil commented Sep 24, 2024

/test all

go.mod Outdated Show resolved Hide resolved
@cardil cardil marked this pull request as ready for review September 24, 2024 20:15
@knative-prow knative-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 24, 2024
internal/ics/app.go Outdated Show resolved Hide resolved
This prevents it from failing with (in some setups):

```
mkdir /.cache: permission denied
```
Copy link
Contributor

@dsimansk dsimansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
Copy link

knative-prow bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
@cardil
Copy link
Contributor Author

cardil commented Sep 26, 2024

@dsimansk Would you mind reviewing da9f541, as well?

I added the above as the PR suppose to fix #356

@dsimansk
Copy link
Contributor

dsimansk commented Oct 2, 2024

/lgtm

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 2, 2024
@knative-prow knative-prow bot merged commit 3f209e4 into knative-extensions:main Oct 2, 2024
24 checks passed
@cardil cardil deleted the feature/sink branch October 2, 2024 10:43
cardil added a commit that referenced this pull request Oct 2, 2024
Align the docs to #368 changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
2 participants