-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💝 Migrating to sink flag for --to param #368
Conversation
Skipping CI for Draft Pull Request. |
ff21200
to
e83a647
Compare
559b1ca
to
b081612
Compare
/test all |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
===========================================
+ Coverage 55.67% 69.26% +13.58%
===========================================
Files 51 48 -3
Lines 1374 1246 -128
===========================================
+ Hits 765 863 +98
+ Misses 540 313 -227
- Partials 69 70 +1 ☔ View full report in Codecov by Sentry. |
b081612
to
018bf5f
Compare
/test all |
018bf5f
to
f86053e
Compare
f86053e
to
b399d9d
Compare
b399d9d
to
ceb59ae
Compare
This prevents it from failing with (in some setups): ``` mkdir /.cache: permission denied ```
eb5f95b
to
76a4108
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Changes
/kind enhancement
Relations
Fixes #282
Fixes #202
Fixes #356
Fixes #160
Requires knative/client#1968
Release Notes
Docs