Repository navigation
Test kind e2e on k8s 1.35 and 1.36 - #1312
Merged
Merged
Conversation
knative.dev/pkg now needs k8s 1.35 or later (knative/pkg#3404), so the controllers no longer start on the v1.34.x kind legs. Drop v1.34.x, add v1.36.x, and pin setup-kind and kind-diag to v1.6.42, as knative/serving#16713 did. Also move actions/checkout from v4 to v7: actionlint now fails on v4's deprecated node20 runtime in any workflow file a PR touches.
knative-prow
Bot
added
the
size/XS
knative-prow
Bot
added
the
approved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1312 +/- ##
=======================================
Coverage 93.67% 93.67%
=======================================
Files 9 9
Lines 680 680
=======================================
Hits 637 637
Misses 22 22
Partials 21 21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
knative.dev/pkg now needs k8s 1.35 or later (knative/pkg#3404), so the controllers no longer start on the v1.34.x kind legs. Drop v1.34.x, add v1.36.x, and pin setup-kind and kind-diag to v1.6.42, as knative/serving#16713 did.
Also move actions/checkout from v4 to v7: actionlint now fails on v4's deprecated node20 runtime in any workflow file a PR touches.
cc @dsimansk