🧹 Dedup knative/client code by using knative/client-pkg

[cardil]

Changes

• 🧹 Dedup knative/client code by using knative/client-pkg

/kind cleanup

Fixes knative-extensions/kn-plugin-event#282

[knative-prow]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cardil
Once this PR has been reviewed and has the lgtm label, please assign krsna-m for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Attention: Patch coverage is 65.97052% with 277 lines in your changes are missing coverage. Please review.

Project coverage is 59.67%. Comparing base (2dec068) to head (a64cce1).
Report is 6 commits behind head on main.

❗ Current head a64cce1 differs from pull request most recent head fe59266. Consider uploading reports for the commit fe59266 to get more accurate results

Files	Patch %	Lines
pkg/util/test/revision.go	0.00%	77 Missing ⚠️
pkg/commands/completion_helper.go	87.68%	18 Missing and 16 partials ⚠️
pkg/util/test/broker.go	0.00%	30 Missing ⚠️
pkg/util/test/subscription.go	0.00%	30 Missing ⚠️
pkg/util/test/channel.go	0.00%	29 Missing ⚠️
pkg/util/test/eventtype.go	0.00%	24 Missing ⚠️
pkg/flags/podspec_helper.go	0.00%	20 Missing ⚠️
pkg/commands/types.go	46.66%	8 Missing ⚠️
pkg/serving/v1/client_mock.go	93.27%	7 Missing and 1 partial ⚠️
pkg/commands/flags/sink/flag.go	74.07%	5 Missing and 2 partials ⚠️
... and 4 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   57.62%   59.67%   +2.05%     
==========================================
  Files         114      127      +13     
  Lines        8418     7934     -484     
==========================================
- Hits         4851     4735     -116     
+ Misses       3303     2910     -393     
- Partials      264      289      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[knative-prow-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cardil]

/hold
/cc @dsimansk
/cc @mvinkler

I think, I'll reconsider this in favor of another idea - to integrate all client code within knative/client itself, but with go modules. Probably some changes are needed for the release script, and some adjustment for Go 1.22 vendor changes, see: golang/go#60056

[github-actions]

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.