Skip to content

🧹 Dedup code by using client-pkg #2676

🧹 Dedup code by using client-pkg

🧹 Dedup code by using client-pkg #2676

Triggered via pull request April 16, 2024 18:17
Status Failure
Total duration 3m 15s
Artifacts

knative-style.yaml

on: pull_request
style  /  changes
5s
style / changes
style  /  ...  /  Auto-format and Check
24s
style / Golang / Auto-format and Check
style  /  ...  /  Lint
2m 52s
style / Golang / Lint
style  /  ...  /  Do Not Submit
6s
style / Golang / Do Not Submit
style  /  ...  /  shell
12s
style / suggester / shell
style  /  ...  /  yaml
18s
style / suggester / yaml
style  /  ...  /  github_actions
0s
style / suggester / github_actions
Matrix: style / Golang / Boilerplate Check
Fit to window
Zoom out
Zoom in

Annotations

15 errors and 6 warnings
style / Golang / Do Not Submit
Process completed with exit code 1.
style / suggester / shell
Process completed with exit code 2.
style / suggester / yaml
Process completed with exit code 1.
style / Golang / Lint
Process completed with exit code 1.
style / Golang / Lint: test/e2e/basic_workflow_test.go#L1
: # knative.dev/client/test/e2e [knative.dev/client/test/e2e.test]
style / Golang / Lint: test/e2e/basic_workflow_test.go#L67
undefined: test.ServiceCreateNoWait
style / Golang / Lint: test/e2e/basic_workflow_test.go#L70
undefined: test.ServiceWait (typecheck)
style / Golang / Lint: pkg/commands/trigger/trigger_test.go#L97
func `createTriggerWithInject` is unused (unused)
style / Golang / Lint: pkg/commands/service/describe.go#L330
SA1019: sets.String is deprecated: use generic Set instead. new ways: s1 := Set[string]{} s2 := New[string]() (staticcheck)
style / Golang / Lint: pkg/commands/service/describe.go#L349
SA1019: sets.String is deprecated: use generic Set instead. new ways: s1 := Set[string]{} s2 := New[string]() (staticcheck)
style / Golang / Lint: pkg/flags/podspec_helper.go#L23
SA1019: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (staticcheck)
style / Golang / Lint
issues found
style / Golang / Lint
Process completed with exit code 1.
style / Golang / Lint
Process completed with exit code 1.
style / Golang / Lint
Process completed with exit code 1.
style / suggester / shell
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
style / suggester / yaml
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/client/client. Supported file pattern: go.sum
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/client/client. Supported file pattern: go.sum
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/client/client. Supported file pattern: go.sum
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/client/client. Supported file pattern: go.sum