Skip to content

feat: make prajjwal UX approver - #1742

Merged
knative-prow[bot] merged 1 commit into
knative:mainfrom
Cali0707:prajjwalyd-ux-approver
Nov 25, 2025
Merged

feat: make prajjwal UX approver#1742
knative-prow[bot] merged 1 commit into
knative:mainfrom
Cali0707:prajjwalyd-ux-approver

Conversation

@Cali0707

Copy link
Copy Markdown
Member

@prajjwalyd has been an active contributor in the UX WG for over 1.5 years now, contributing many improvements and reviews. This includes acting as a mentor for the most recent LFX term. I believe @prajjwalyd is more than ready to become a UX approver, so this PR adds him as one.

Changes

  • Add UX approver group (there was only UX leads before)
  • Make @prajjwalyd a UX approver

@knative-prow knative-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 25, 2025
@Cali0707

Copy link
Copy Markdown
Member Author

/cc @aliok @Leo6Leo @dprotaso

@knative-prow
knative-prow Bot requested review from Leo6Leo and dprotaso November 25, 2025 13:58
@prajjwalyd

Copy link
Copy Markdown
Member

I agree, and am looking forward to becoming an approver for the UX repo!

Signed-off-by: Calum Murray <cmurray@redhat.com>
@Cali0707
Cali0707 force-pushed the prajjwalyd-ux-approver branch from 39f0d8a to 2fa31fc Compare November 25, 2025 14:50
@knative-prow knative-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 25, 2025
@Leo6Leo

Leo6Leo commented Nov 25, 2025

Copy link
Copy Markdown
Member

Agree, thanks for all the effort you've put to Knative @prajjwalyd !
/lgtm
Will leave approve labels to the rest of the members that @Cali0707 cced

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2025
@dprotaso

Copy link
Copy Markdown
Member

/approve

@knative-prow

knative-prow Bot commented Nov 25, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2025
@knative-prow
knative-prow Bot merged commit 00ae5b0 into knative:main Nov 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants