Skip to content

drop references to old net-cert-manager controller - #6333

Merged
knative-prow[bot] merged 1 commit into
knative:mainfrom
dprotaso:drop-net-cert-manager-references
Aug 14, 2025
Merged

drop references to old net-cert-manager controller#6333
knative-prow[bot] merged 1 commit into
knative:mainfrom
dprotaso:drop-net-cert-manager-references

Conversation

@dprotaso

Copy link
Copy Markdown
Member

/assign @dsimansk

@netlify

netlify Bot commented Aug 14, 2025

Copy link
Copy Markdown

Deploy Preview for knative ready!

Name Link
🔨 Latest commit f5acbbe
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/689df10a8849c00008afde6a
😎 Deploy Preview https://deploy-preview-6333--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dprotaso

Copy link
Copy Markdown
Member Author

/cherry-pick release-1.19

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2025
@knative-prow
knative-prow Bot requested review from Cali0707 and matzew August 14, 2025 14:22
@knative-prow knative-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 14, 2025
@knative-prow-robot

Copy link
Copy Markdown
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.19 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso

Copy link
Copy Markdown
Member Author

/cherry-pick release-1.18

@knative-prow-robot

Copy link
Copy Markdown
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.18 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso

Copy link
Copy Markdown
Member Author

/cherry-pick release-1.17

@knative-prow-robot

Copy link
Copy Markdown
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.17 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso

Copy link
Copy Markdown
Member Author

/assign @Fedosin

@evankanderson evankanderson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I'm assuming this got merged into the serving controller.

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2025
@knative-prow

knative-prow Bot commented Aug 14, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [dprotaso,evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow
knative-prow Bot merged commit 0065b40 into knative:main Aug 14, 2025
19 checks passed
@knative-prow-robot

Copy link
Copy Markdown
Contributor

@dprotaso: new pull request created: #6334

Details

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot

Copy link
Copy Markdown
Contributor

@dprotaso: new pull request created: #6335

Details

In response to this:

/cherry-pick release-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot

Copy link
Copy Markdown
Contributor

@dprotaso: new pull request created: #6336

Details

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso

Copy link
Copy Markdown
Member Author

yup ages ago

@dprotaso
dprotaso deleted the drop-net-cert-manager-references branch August 14, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants