Skip to content

refactor: Replace Telepresence with ko --debug#8869

Merged
knative-prow[bot] merged 2 commits into
knative:mainfrom
Arpit529Srivastava:debug-flag
Feb 9, 2026
Merged

refactor: Replace Telepresence with ko --debug#8869
knative-prow[bot] merged 2 commits into
knative:mainfrom
Arpit529Srivastava:debug-flag

Conversation

@Arpit529Srivastava

Copy link
Copy Markdown
Contributor

Fixes #7099

Proposed Changes

  • 🧹 Replace Telepresence debugging documentation with ko --debug approach
  • 🧹 Add instructions for VSCode and IntelliJ/GoLand remote debugging via Delve
  • 🧹 Add troubleshooting section for common debugging issues

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact; docs update itself (DEVELOPMENT.md)
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

updated `DEVELOPMENT.md` to use ko’s built-in `--debug` flag for remote debugging instead of telepresence. this simplifies the debugging workflow by using delve directly and avoids introducing extra dependencies.

Docs
this pr updates the developer documentation (DEVELOPMENT.md) in this repository. no external documentation changes are needed since this only affects the development workflow and not any user-facing features.

Signed-off-by: arpit529srivastava <arpitsrivastava529@gmail.com>
@knative-prow

knative-prow Bot commented Feb 1, 2026

Copy link
Copy Markdown

Welcome @Arpit529Srivastava! It looks like this is your first PR to knative/eventing 🎉

@knative-prow knative-prow Bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 1, 2026
@knative-prow

knative-prow Bot commented Feb 1, 2026

Copy link
Copy Markdown

Hi @Arpit529Srivastava. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow Bot requested review from Cali0707 and Leo6Leo February 1, 2026 21:37
@Arpit529Srivastava

Copy link
Copy Markdown
Contributor Author

/cc @creydr PTAL,
thanks.

@creydr creydr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @Arpit529Srivastava for improving this.
I left two comments

Comment thread DEVELOPMENT.md Outdated
```

## Debugging Knative controllers and friends locally
## Debugging Knative controllers and webhooks

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Debugging Knative controllers and webhooks
## Debugging Knative controllers and friends locally

I'd keep the initial version here, because everything what is build with ko in knative can be debugged

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see, made the changes :)

Comment thread DEVELOPMENT.md
Comment on lines +395 to +413
{
"version": "0.2.0",
"configurations": [
{
"name": "Connect to Eventing Controller",
"type": "go",
"request": "attach",
"mode": "remote",
"port": 40000,
"host": "127.0.0.1",
"substitutePath": [
{
"from": "${workspaceFolder}",
"to": "/go/src/knative.dev/eventing"
}
]
}
]
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@twoGiants as you're working a lot with VSCode: is all of this needed to use ko debug?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the substitutePath is there to map the local workspace path to the go module path inside the container, so vscode can correctly resolve source locations for breakpoints. that said, i'll wait for @twoGiants's review.

@creydr creydr Feb 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked my old config and I simply used

"cwd": "${workspaceFolder}"

instead of the substitutePath. That way we don't need the substitution I guess

(and "host": "0.0.0.0",)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made the requested changes 👍🏻

@Arpit529Srivastava

Copy link
Copy Markdown
Contributor Author

Thanks a lot @Arpit529Srivastava for improving this. I left two comments

addressed, thanks for the review :)

@Arpit529Srivastava

Copy link
Copy Markdown
Contributor Author

@creydr a gentle ping, thanks :)

Signed-off-by: arpit529srivastava <arpitsrivastava529@gmail.com>
@Arpit529Srivastava

Copy link
Copy Markdown
Contributor Author

@creydr PTAL, when you get time, thanks

@creydr

creydr commented Feb 9, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@knative-prow knative-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 9, 2026
@codecov

codecov Bot commented Feb 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.63%. Comparing base (0ef7bc1) to head (00d9ac0).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8869      +/-   ##
==========================================
- Coverage   51.11%   50.63%   -0.48%     
==========================================
  Files         409      409              
  Lines       21381    21658     +277     
==========================================
+ Hits        10928    10966      +38     
- Misses       9602     9835     +233     
- Partials      851      857       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Arpit529Srivastava

Copy link
Copy Markdown
Contributor Author

@creydr should i update the branch to latest commit?

@creydr creydr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on this @Arpit529Srivastava
/lgtm

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2026
@knative-prow

knative-prow Bot commented Feb 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Arpit529Srivastava, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2026
@knative-prow knative-prow Bot merged commit 9e76da0 into knative:main Feb 9, 2026
35 of 36 checks passed
@Arpit529Srivastava Arpit529Srivastava deleted the debug-flag branch February 9, 2026 14:13
@Arpit529Srivastava

Copy link
Copy Markdown
Contributor Author

Thanks a lot for working on this @Arpit529Srivastava /lgtm

thanks for reviewing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create hack/telepresence script

2 participants