refactor: Replace Telepresence with ko --debug#8869
Conversation
Signed-off-by: arpit529srivastava <arpitsrivastava529@gmail.com>
|
Welcome @Arpit529Srivastava! It looks like this is your first PR to knative/eventing 🎉 |
|
Hi @Arpit529Srivastava. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cc @creydr PTAL, |
creydr
left a comment
There was a problem hiding this comment.
Thanks a lot @Arpit529Srivastava for improving this.
I left two comments
| ``` | ||
|
|
||
| ## Debugging Knative controllers and friends locally | ||
| ## Debugging Knative controllers and webhooks |
There was a problem hiding this comment.
| ## Debugging Knative controllers and webhooks | |
| ## Debugging Knative controllers and friends locally |
I'd keep the initial version here, because everything what is build with ko in knative can be debugged
There was a problem hiding this comment.
i see, made the changes :)
| { | ||
| "version": "0.2.0", | ||
| "configurations": [ | ||
| { | ||
| "name": "Connect to Eventing Controller", | ||
| "type": "go", | ||
| "request": "attach", | ||
| "mode": "remote", | ||
| "port": 40000, | ||
| "host": "127.0.0.1", | ||
| "substitutePath": [ | ||
| { | ||
| "from": "${workspaceFolder}", | ||
| "to": "/go/src/knative.dev/eventing" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
@twoGiants as you're working a lot with VSCode: is all of this needed to use ko debug?
There was a problem hiding this comment.
the substitutePath is there to map the local workspace path to the go module path inside the container, so vscode can correctly resolve source locations for breakpoints. that said, i'll wait for @twoGiants's review.
There was a problem hiding this comment.
I just checked my old config and I simply used
"cwd": "${workspaceFolder}"
instead of the substitutePath. That way we don't need the substitution I guess
(and "host": "0.0.0.0",)
There was a problem hiding this comment.
made the requested changes 👍🏻
addressed, thanks for the review :) |
|
@creydr a gentle ping, thanks :) |
Signed-off-by: arpit529srivastava <arpitsrivastava529@gmail.com>
e44c38c to
00d9ac0
Compare
|
@creydr PTAL, when you get time, thanks |
|
/ok-to-test |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8869 +/- ##
==========================================
- Coverage 51.11% 50.63% -0.48%
==========================================
Files 409 409
Lines 21381 21658 +277
==========================================
+ Hits 10928 10966 +38
- Misses 9602 9835 +233
- Partials 851 857 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@creydr should i update the branch to latest commit? |
creydr
left a comment
There was a problem hiding this comment.
Thanks a lot for working on this @Arpit529Srivastava
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Arpit529Srivastava, creydr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks for reviewing :) |
Fixes #7099
Proposed Changes
ko --debugapproachPre-review Checklist
Release Note
Docs
this pr updates the developer documentation (
DEVELOPMENT.md) in this repository. no external documentation changes are needed since this only affects the development workflow and not any user-facing features.