Skip to content

Revert "feat: add possibility to disable pushing of image in deploy command" #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

zroubalik
Copy link
Contributor

@zroubalik zroubalik commented Jan 6, 2022

Reverts #736

This change hasn't been ready yet/

@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 6, 2022
@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #738 (c82ce46) into main (4e5a5e8) will decrease coverage by 0.00%.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #738      +/-   ##
==========================================
- Coverage   41.56%   41.56%   -0.01%     
==========================================
  Files          42       42              
  Lines        4102     4083      -19     
==========================================
- Hits         1705     1697       -8     
+ Misses       2144     2135       -9     
+ Partials      253      251       -2     
Impacted Files Coverage Δ
cmd/deploy.go 16.17% <0.00%> (+0.13%) ⬆️
client.go 65.08% <33.33%> (+0.06%) ⬆️
cmd/build.go 58.08% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e5a5e8...c82ce46. Read the comment docs.

@zroubalik zroubalik requested review from salaboy and lance January 6, 2022 15:56
@lance
Copy link
Member

lance commented Jan 6, 2022

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2022
@knative-prow-robot knative-prow-robot merged commit 2282cf8 into main Jan 6, 2022
@lance lance deleted the revert-736-dpush branch February 22, 2022 23:17
jrangelramos added a commit to jrangelramos/func that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants