Skip to content

Fix linter issues after k8s update - #16706

Merged
knative-prow[bot] merged 1 commit into
knative:mainfrom
dsimansk:pr/fix-linter-errors
Oct 17, 2026
Merged

knative-prow[bot] merged 1 commit into
knative:mainfrom
dsimansk:pr/fix-linter-errors

Conversation

@dsimansk

Copy link
Copy Markdown
Contributor

Fixes #

Proposed Changes

  • Fix linter issues after k8s update

Release Note

Fix linter issues after k8s update

/cc @dprotaso @knative/steering-committee

@knative-prow
knative-prow Bot requested review from a team and dprotaso October 16, 2026 10:41
@knative-prow knative-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 16, 2026
@codecov

codecov Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.51613% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.35%. Comparing base (a5a712d) to head (0bcc4d9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/testing/v1/service.go 0.00% 5 Missing ⚠️
pkg/testing/v1/revision.go 0.00% 4 Missing ⚠️
pkg/testing/v1/configuration.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16706      +/-   ##
==========================================
+ Coverage   80.32%   80.35%   +0.02%     
==========================================
  Files         217      217              
  Lines       13560    13560              
==========================================
+ Hits        10892    10896       +4     
+ Misses       2306     2301       -5     
- Partials      362      363       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@evankanderson evankanderson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2026
@knative-prow

knative-prow Bot commented Oct 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2026
@knative-prow
knative-prow Bot merged commit b6c3209 into knative:main Oct 17, 2026
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants