Repository navigation
Conversation
The activator-capacity comment linked to a private Google doc through a bit.ly short link. Replace the link with a description of how the number of activators is computed (see computeNumActivators in pkg/reconciler/autoscaling/kpa/kpa.go) and regenerate the example checksum. Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
|
Hi @cvas22. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cvas22 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Fixes #16676
Proposed Changes
activator-capacitycomment inconfig/core/configmaps/autoscaler.yamlpointed tohttps://bit.ly/38XiCZ3, which redirects to a Google doc that is not publicly accessible. The link is replaced with a short description of how the activator subset size is computed, matchingcomputeNumActivatorsinpkg/reconciler/autoscaling/kpa/kpa.go: 2 activators when the target burst capacity is 0, otherwisemax(2, ceil(capacity / activator-capacity)), where capacity is ready pods times the per-pod total metric value, plus the target burst capacity when positive.knative.dev/example-checksumannotation withhash-gen(whathack/update-checksums.shruns).Comment-only change; no behaviour change.
Tests run locally (Windows, Go 1.26):
go test ./pkg/autoscaler/config/... ./pkg/reconciler/autoscaling/config/...pass (with the testdata symlinks materialised, since Windows checks them out as plain files).TestNewConfigfails with the old checksum and passes with the regenerated one. Not run: the full unit suite, linters and e2e tests; relying on CI for those.Disclosure: I prepared this change with the help of an AI coding assistant. I reviewed the diff and take responsibility for it.
Release Note