Skip to content

Replace private doc link in activator-capacity comment - #16708

Open
cvas22 wants to merge 1 commit into
knative:mainfrom
cvas22:fix/16676-activator-capacity-doc-link
Open

cvas22 wants to merge 1 commit into
knative:mainfrom
cvas22:fix/16676-activator-capacity-doc-link

Conversation

@cvas22

@cvas22 cvas22 commented Oct 18, 2026

Copy link
Copy Markdown

Fixes #16676

Proposed Changes

  • The activator-capacity comment in config/core/configmaps/autoscaler.yaml pointed to https://bit.ly/38XiCZ3, which redirects to a Google doc that is not publicly accessible. The link is replaced with a short description of how the activator subset size is computed, matching computeNumActivators in pkg/reconciler/autoscaling/kpa/kpa.go: 2 activators when the target burst capacity is 0, otherwise max(2, ceil(capacity / activator-capacity)), where capacity is ready pods times the per-pod total metric value, plus the target burst capacity when positive.
  • Regenerated the knative.dev/example-checksum annotation with hash-gen (what hack/update-checksums.sh runs).

Comment-only change; no behaviour change.

Tests run locally (Windows, Go 1.26): go test ./pkg/autoscaler/config/... ./pkg/reconciler/autoscaling/config/... pass (with the testdata symlinks materialised, since Windows checks them out as plain files). TestNewConfig fails with the old checksum and passes with the regenerated one. Not run: the full unit suite, linters and e2e tests; relying on CI for those.

Disclosure: I prepared this change with the help of an AI coding assistant. I reviewed the diff and take responsibility for it.

Release Note

NONE

The activator-capacity comment linked to a private Google doc through a
bit.ly short link. Replace the link with a description of how the number
of activators is computed (see computeNumActivators in
pkg/reconciler/autoscaling/kpa/kpa.go) and regenerate the example checksum.

Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
@knative-prow knative-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 18, 2026
@knative-prow

knative-prow Bot commented Oct 18, 2026

Copy link
Copy Markdown

Hi @cvas22. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow

knative-prow Bot commented Oct 18, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cvas22
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comment reference to a private Google doc

1 participant