Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack4 updation #15

Open
wants to merge 1 commit into
base: webpack-4
Choose a base branch
from
Open

Conversation

akash11196
Copy link

Hi @ashokdey I have updated the webpack version from 3 to 4 and created a pull request just as told please do look in to it and let me know in case of any issues

@akash11196 akash11196 mentioned this pull request Oct 6, 2019
4 tasks
@ashokdey ashokdey self-requested a review October 10, 2019 16:23
@ashokdey ashokdey added beginner friendly enhancement New feature or request Hacktoberfest Start your open source journey this October under review labels Oct 10, 2019
Copy link
Member

@ashokdey ashokdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should never have beta versions in the final build.

@@ -17,7 +17,7 @@
},
"dependencies": {
"axios": "^0.18.0",
"extract-text-webpack-plugin": "^3.0.2",
"extract-text-webpack-plugin": "^4.0.0-beta.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beta version should not be there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner friendly changes required enhancement New feature or request Hacktoberfest Start your open source journey this October under review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants