Ansible host variable fixes #162
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ah hmmm did not mean to do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue (attempts to) address the issue identified in #161 by updating some of the ansible configs to use a newer variable name to access the ssh hostname.
Approach
Disclosure: I approached this fix with a largely automated find-and-replace strategy
Testing and possible drawbacks to this PR
My my testing this seems to resolve the issue, but since im less familar with how ansible works, I have not verified whether this is the minimal possible set of changes needed to solve the issue
I also have not checked to see whether this change breaks any other aspects of the ansible config.
fixes #161