Skip to content

PubSubClient: Add failure test into readByte() #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

PubSubClient: Add failure test into readByte() #988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/PubSubClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,7 @@ boolean PubSubClient::connect(const char *id, const char *user, const char *pass

// reads a byte into result
boolean PubSubClient::readByte(uint8_t * result) {
int rc;
uint32_t previousMillis = millis();
while(!_client->available()) {
yield();
Expand All @@ -294,8 +295,13 @@ boolean PubSubClient::readByte(uint8_t * result) {
return false;
}
}
*result = _client->read();
return true;
rc = _client->read();
if(rc >= 0) {
rxCount++;
*result = rc;
return true;
}
return false;
}

// reads a byte into result[*index] and increments index
Expand Down