Skip to content

Support newer Postgresql version that use leading commas #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

himynameisjonas
Copy link

No description provided.

Copy link
Owner

@knu knu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but I have no reason to rename the gem and I cannot accept the name change. Can you remove that?

@himynameisjonas
Copy link
Author

Looks great, but I have no reason to rename the gem and I cannot accept the name change. Can you remove that?

Ops, I forgot that I used the master branch when opening this PR.
I created a fork so we could use this fix since there was no activity in this repo. Will sort this out.

@himynameisjonas
Copy link
Author

I've removed that commit now!

@louim
Copy link

louim commented Jul 11, 2024

Hey @himynameisjonas! As far as I'm aware, the Rails team decided to reverse the order of migrations instead of using leading commas. See this PR: rails/rails#44363 and this bit of code.

@Joe-Degler
Copy link

Until this gets updated, I forked the repo to fix the reversed order of migrations and released it on rubygems:

https://github.com/Joe-Degler/git-driver-merge-structure-sql
https://rubygems.org/gems/git-driver-merge-structure-sql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants