Skip to content

Conversation

@jonathanpallant
Copy link
Contributor

Updates the qemu-run binary so we can publish it and use it elsewhere.

@jonathanpallant jonathanpallant marked this pull request as draft November 7, 2025 12:31
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 7, 2025

Deploying knurling-defmt-book with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1d1ebc8
Status: ✅  Deploy successful!
Preview URL: https://026ac68e.knurling-defmt-book.pages.dev
Branch Preview URL: https://update-qemu-run.knurling-defmt-book.pages.dev

View logs

@jonathanpallant
Copy link
Contributor Author

Fixed formatting, and added a CHANGELOG section for it.

Assumes we'll do a 0.1.0 release as soon as this PR merges.
Now uses log::info! etc to add host logs, which are mixed with device logs
It looks terrible at the start of the line.
@jonathanpallant jonathanpallant marked this pull request as ready for review November 7, 2025 16:16
Now that qemu-run uses defmt-decoder's log function rather than
"frame.display()", we:

* get padding on the log level (so "INFO" is "INFO ")
* don't get timestamps in defmt::println! output
* get asserts formatted differently

This doesn't affect any output our users will see. If anything, it
brings the snapshot tests closer in line with what users see currently
(as qemu-run was a private internal tool and users use defmt-print or
probe-rs).
@jonathanpallant
Copy link
Contributor Author

Ping @robamu on this one as well

@jonathanpallant
Copy link
Contributor Author

mdbook test -L ../target/debug -L ../target/debug/deps -L ../firmware/target/debug -L ../firmware/target/debug/deps
ERROR Invalid configuration file
	Caused by: TOML parse error at line 4, column 1
  |
4 | multilingual = false
  | ^^^^^^^^^^^^
unknown field `multilingual`, expected one of `title`, `authors`, `description`, `src`, `language`, `text-direction`

Did we not pin down the version of mdbook we use? We should do that.

@robamu
Copy link

robamu commented Nov 21, 2025

Did we not pin down the version of mdbook we use? We should do that.

sounds like a good thing to do.

This tool could be useful for some of the stuff I did in embedded-alloc as well..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants