Skip to content

Conversation

@jamesmunns
Copy link
Contributor

Fixes #1021

This seems to resolve the issues I see in a basic test in embedded-hal.

@jamesmunns
Copy link
Contributor Author

I'm open to suggestions on how to add a regression test for this, I'm not super familiar with defmt's test stack, but something as simple as this is enough to trigger at least a basic check:

cargo new dfmt-regress
cd dfmt-regress
cargo add embedded-hal --features=defmt-03
echo '[patch.crates-io]\ndefmt = { path = "PATH/TO/defmt/defmt" }' >> Cargo.toml
cargo check

@jonathanpallant
Copy link
Contributor

Good catch, thanks! I don't know I'll be able to get a patch release out - maybe Monday?

@jamesmunns
Copy link
Contributor Author

Not a huge deal/rush for now, for testing we've just tweaked defmt anyway and patched that too. Just wanted to share findings made along the way :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues with patching on current defmt

2 participants