chore: prefer node:test; normalize#181
Merged
Merged
Conversation
79522d4 to
2a71493
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #181 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 33 73 +40
Branches 12 0 -12
=========================================
+ Hits 33 73 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2a71493 to
a8a0888
Compare
5b0b717 to
334faf9
Compare
jonathanong
reviewed
May 19, 2025
| return x && typeof x.then === 'function' | ||
| } | ||
|
|
||
| function testBaseFunctionality() { |
Member
Author
There was a problem hiding this comment.
Just changed how tests are executed when changing the test runner. Want me to switch it back?
Member
There was a problem hiding this comment.
yeah, we want the whole suite to run in both envs. looks like only 1 test runs in prod
bce91ad to
995f160
Compare
jonathanong
reviewed
May 24, 2025
| assert.deepStrictEqual(ctx, { middleware: 1, next: 1 }) | ||
| }) | ||
|
|
||
| await test('production mode', async (t) => { |
Member
There was a problem hiding this comment.
I don't think test() returns anything, so the await here does nothing
4e30194 to
995f160
Compare
2b5c28c to
0e2fe84
Compare
jonathanong
approved these changes
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
node:assert/test#182