Skip to content

chore: prefer node:test; normalize#181

Merged
yowainwright merged 1 commit into
masterfrom
1870-v4-prefer-node-test
May 25, 2025
Merged

chore: prefer node:test; normalize#181
yowainwright merged 1 commit into
masterfrom
1870-v4-prefer-node-test

Conversation

@yowainwright

@yowainwright yowainwright commented May 17, 2025

Copy link
Copy Markdown
Member

Checklist


  • Prefer node:assert/test
  • Normalize scripts to be like koa core

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@yowainwright yowainwright force-pushed the 1870-v4-prefer-node-test branch 2 times, most recently from 79522d4 to 2a71493 Compare May 17, 2025 20:51
@codecov

codecov Bot commented May 17, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a8a0888) to head (0e2fe84).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #181   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           33        73   +40     
  Branches        12         0   -12     
=========================================
+ Hits            33        73   +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yowainwright yowainwright force-pushed the 1870-v4-prefer-node-test branch from 2a71493 to a8a0888 Compare May 17, 2025 20:59
@yowainwright yowainwright reopened this May 17, 2025
@yowainwright yowainwright force-pushed the 1870-v4-prefer-node-test branch 3 times, most recently from 5b0b717 to 334faf9 Compare May 17, 2025 21:12
@yowainwright yowainwright marked this pull request as ready for review May 17, 2025 21:14
Comment thread test/test.js
return x && typeof x.then === 'function'
}

function testBaseFunctionality() {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we remove this?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just changed how tests are executed when changing the test runner. Want me to switch it back?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, we want the whole suite to run in both envs. looks like only 1 test runs in prod

@yowainwright yowainwright marked this pull request as draft May 24, 2025 18:46
@yowainwright yowainwright force-pushed the 1870-v4-prefer-node-test branch from bce91ad to 995f160 Compare May 24, 2025 18:48
@yowainwright yowainwright marked this pull request as ready for review May 24, 2025 18:50
Comment thread test/test.js Outdated
assert.deepStrictEqual(ctx, { middleware: 1, next: 1 })
})

await test('production mode', async (t) => {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think test() returns anything, so the await here does nothing

@yowainwright yowainwright force-pushed the 1870-v4-prefer-node-test branch 2 times, most recently from 4e30194 to 995f160 Compare May 24, 2025 20:15
@yowainwright yowainwright force-pushed the 1870-v4-prefer-node-test branch from 2b5c28c to 0e2fe84 Compare May 25, 2025 01:47
@yowainwright yowainwright merged commit 9a2a426 into master May 25, 2025
11 checks passed
@yowainwright yowainwright deleted the 1870-v4-prefer-node-test branch May 25, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[task] pivot tests to node:assert/test

2 participants