Open
Conversation
falkenhawk
reviewed
Apr 6, 2023
package.json
Outdated
| }, | ||
| "engines": { | ||
| "node": ">= 4" | ||
| "node": ">= 14" |
There was a problem hiding this comment.
bumping node min version to 14 is not necessary, ioredis v5 states that it is still compatible with node v12.
https://github.com/luin/ioredis/wiki/Upgrading-from-v4-to-v5
and in its package.json it is set to >= 12.22.0
https://github.com/luin/ioredis/blob/92aefaac13f42ad14986fde47c640ff8edc415ef/package.json#L92
Author
There was a problem hiding this comment.
Thanks for the feedback @falkenhawk. I updated the version to match ioredis.
…configurable, and move ioredis to peer dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
REDIS_URLenv variable to allow the redis test server to be configurable on local envsyarn.lockfile.Checklist