fix(demographics): retry transient WPP page failures - #7580
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A transient UN WPP HTTP 502 exhausted the two-attempt page retry contract. The seeder safely retained the last WPP section, but
demographicsCapabilitystayed atCOVERAGE_PARTIALwith two of three stages fresh. Seven later read-only WPP stage probes returned HTTP 200 for all ten page requests and passed all five metric floors for 229 countries. This supports an upstream transient, not a schema or coverage change.Scope
Tradeoffs
A persistent WPP failure can now use 1.5 seconds of retry delay instead of 250 milliseconds. This remains inside the existing 45-second stage deadline. The error log includes a public UN query URL and no credential.
Blast Radius
The runtime change affects only the WPP stage of the demographics static-reference seed. The investigation made no Redis write and did not start a production seeder. Production remains partial until one deployed run completes all three source stages.
Verification
node --test tests/demographics-capability-seed.test.mjspassed 20 tests.npm run test:datapassed 29,483 tests with 35 skipped and no failures.npm run lint:boundariespassed.Post-Deploy Monitoring & Validation
seed-bundle-static-refproduction run within 30 minutes after it ends.Demographics-Capabilityanddemographics:wpp. Healthy evidence isrecords=229 state=OKwith no WPP error.seed-meta:demographics:capability-completehas the same run timestamp./api/health?compact=1with a cache-busting parameter. Accept onlycoverage.status=complete,completedPages=3,failedPages=0,completionRatio=1, and at least 229 records.