feat(tooling): attach visual evidence to pull requests - #7587
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Print === Done (Nms) === as the last act of the CLI success path so crash diagnostics can tell a clean run from a silent death.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Reviewers can now get the curated E2E screenshot gallery directly in a pull request comment. This uses GitHub CLI 2.99 media attachments and keeps the existing Actions artifacts for traces and videos.
Scope
npm run --silent agent:attach-pr-evidence -- --pr <number> --run-id <run-id>for an authenticated maintainer checkout.Tradeoffs
The publisher is a trusted local command. A normal Actions
GITHUB_TOKENuses a token type that the GitHub CLI attachment client does not accept, so this change adds no long-lived secret or broader workflow permission.The command rejects fork pull requests, stale heads, failed gallery jobs, expired artifacts, and ambiguous artifact sets. A maintainer must choose the pull request and successful run explicitly.
Blast radius
This change affects local agent tooling and test contracts only. It does not change the browser app, the E2E workflow, the existing object-storage publisher, or production behavior.
Verification
node --test tests/publish-pr-media-evidence.test.mjs tests/e2e-visual-workflow.test.mjspassed 22 tests.git diff --check origin/main...HEADpassed.