fix(redis): prefix temporal baseline lock - #7595
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
koala73
enabled auto-merge (squash)
September 3, 2026 12:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Issue #7575 found that the temporal-anomalies rebuild lock bypassed the Redis deployment key prefix. Preview deployments could therefore contend on the production lock while their cache reads and writes used a preview namespace.
The fix uses the existing
setCachedJsonIfAbsentcontract. That helper applies the deployment prefix and preserves the existing NX and expiry behavior.Scope
tryAcquireLockinserver/worldmonitor/infrastructure/v1/list-temporal-anomalies.tsnow usessetCachedJsonIfAbsent.tests/temporal-anomalies-cache.test.mtsverifies the preview lock key.mgetJsonhelper is already removed from currentmainby fix(baselines): validate and rate-sample browser-reported baseline writes #7573. This PR fixes the remaining live raw lock path.Blast Radius
This changes only the temporal-anomalies rebuild lock. Production keeps the unprefixed key. Preview and development deployments now use their own prefixed lock keys. The stale-cache fallback and lock contention behavior remain unchanged.
Verification
baseline:lock.npm run typecheck:apipassed.npm run lint:boundariespassed.npm run lintpassed. The repository reported 53 existing warnings and 12 infos.npm run test:datapassed with 29,746 passed, 0 failed, and 37 skipped.