Skip to content

Conversation

@duvld
Copy link
Member

@duvld duvld commented Sep 18, 2025

🗒️ Checklist

  1. run linter locally
  2. update developer docs (API, README, inline, etc.), if any
  3. for user-facing doc changes create a Zulip thread at #Kobo support docs, if any
  4. draft PR with a title <type>(<scope>)<!>: <title> DEV-1234
  5. assign yourself, tag PR: at least Front end and/or Back end or workflow
  6. fill in the template below and delete template comments
  7. review thyself: read the diff and repro the preview as written
  8. open PR & confirm that CI passes & request reviewers, if needed
  9. delete this section before merging

📣 Summary

Use the new table component to display asset usage data. Fixes old pagination issues

💭 Notes

Modeled after how access logs uses the universal table. Removes uid from the AssetWithUsage type as it is not actually expected as a response from backend--updated logic accordingly

👀 Preview steps

  1. ℹ️ have an account and many projects
  2. submit some data
  3. navigate to account/usage > per project total tab
  4. 🔴 [on main] notice that pagination doesn't work
  5. 🟢 [on PR] notice that pagination does work
  6. 🟢 [on PR] notice that table displays the correct data with no regressions
  7. ℹ️ have a MMO with different member's permissions
  8. 🟢 notice that the table has no regressions related to MMOs

@magicznyleszek
Copy link
Member

@duvld you forgot to add task id in PR title :)

@duvld duvld changed the title fix(assetUsage): migrate asset usage table fix(assetUsage): migrate asset usage table DEV-1013 Sep 30, 2025
@duvld duvld marked this pull request as draft September 30, 2025 15:00
@duvld duvld marked this pull request as ready for review September 30, 2025 17:28
@jamesrkiger
Copy link
Contributor

jamesrkiger commented Oct 1, 2025

Let's give the table a set height so the sort dropdowns don't get cut off if you only have one asset like here:
image

This would also make it so the table doesn't jump sizes when you switch from a page of 10 results to a page of 1 result, for example.

Also, there is currently some horizontal overflow, seemingly no matter how wide my screen is. It's fine if there is horizontal overflow on small screens, but can you fix the column sizes so there is no overflow on normal screens?

Copy link
Contributor

@jamesrkiger jamesrkiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple comments, but it's looking good so far.

@magicznyleszek magicznyleszek removed their request for review October 3, 2025 09:31
@duvld duvld force-pushed the anji/dev-1013-mirgrate-to-universal-table branch from 82c907d to 2de2fa1 Compare November 5, 2025 15:55
commit 82c907d
Merge: 307c0cc 8c71fd2
Author: Anji <[email protected]>
Date:   Tue Oct 14 10:59:11 2025 -0400

    Merge branch 'dev-987-asset-usage-limit-offset-pagination' into anji/dev-1013-mirgrate-to-universal-table

commit 307c0cc
Merge: d1bbb52 6e62f77
Author: Anji <[email protected]>
Date:   Tue Oct 14 10:58:28 2025 -0400

    Merge branch 'dev-987-asset-usage-limit-offset-pagination' into anji/dev-1013-mirgrate-to-universal-table

     Conflicts:
    	jsapp/js/account/usage/usageProjectBreakdown.tsx

commit d1bbb52
Author: Kalvis Kalniņš <[email protected]>
Date:   Thu Oct 9 18:45:26 2025 +0300

    fixup! WIP, BROKEN: query error typing mismatch

commit 1314ccc
Author: Kalvis Kalniņš <[email protected]>
Date:   Thu Oct 9 18:40:33 2025 +0300

    refactor(UniversalTable): parameterize error type

commit 133d677
Author: Anji <[email protected]>
Date:   Thu Oct 9 11:33:00 2025 -0400

    WIP, BROKEN: query error typing mismatch

commit bda0843
Author: Leszek <[email protected]>
Date:   Tue Sep 30 21:04:47 2025 +0200

    remove duplicated column

commit f175294
Author: Anji <[email protected]>
Date:   Tue Sep 30 13:44:05 2025 -0400

    Add count

commit a13fdf4
Author: Anji <[email protected]>
Date:   Tue Sep 30 13:26:51 2025 -0400

    add proper link to project label

commit d58cc9f
Author: Anji <[email protected]>
Date:   Thu Sep 25 15:06:54 2025 -0400

    WIP title link

commit 94f54d6
Merge: 9d98814 4e7c317
Author: Anji Tong <[email protected]>
Date:   Thu Sep 25 17:23:27 2025 +0000

    Merge branch 'dev-987-asset-usage-limit-offset-pagination' into anji/dev-1013-mirgrate-to-universal-table

commit 9d98814
Author: Anji <[email protected]>
Date:   Thu Sep 18 19:22:31 2025 -0400

    biome

commit 0772fad
Author: Anji <[email protected]>
Date:   Thu Sep 18 19:21:22 2025 -0400

    fix(assetUsage): migrate asset usage table

commit 3fc4877
Author: Anji <[email protected]>
Date:   Thu Sep 18 18:58:35 2025 -0400

    WIP: table migrated, TODO: remove old code
@duvld duvld force-pushed the anji/dev-1013-mirgrate-to-universal-table branch from 2de2fa1 to 09b5623 Compare November 5, 2025 15:59
@duvld duvld marked this pull request as draft November 6, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants