chore(dependencies): bump biome to 2.3.1 DEV-939

biome.jsonc

@@ -1,21 +1,20 @@
 {
-  "$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
+  "$schema": "https://biomejs.dev/schemas/2.3.1/schema.json",
   "files": {
-    "ignore": [
-      "node_modules/**",
-      "jsapp/compiled/**",
-      "*.css",
-      // Ignore generated OpenAPI schema.
-      "static/openapi/*",
-      // Ignore minified committed JS files.
-      "*.min.js",
-      "*-min.js",
-      "bootstrap*.js",
-      "jquery*.js",
-      "kobo/apps/openrosa/apps/logger/fixtures/*",
-      "kpi/static/js/swagger/swagger-ui-bundle.js",
-      "kpi/static/js/swagger/swagger-ui-standalone-preset.js",
-      "msw-mocks/*"
+    "includes": [
+      "**",
+      "!**/node_modules",
+      "!**/jsapp/compiled",
+      "!**/*.css",
+      "!**/static/openapi/**/*",
+      "!**/*.min.js",
+      "!**/*-min.js",
+      "!**/bootstrap*.js",
+      "!**/jquery*.js",
+      "!**/kobo/apps/openrosa/apps/logger/fixtures/**/*",
+      "!**/kpi/static/js/swagger/swagger-ui-bundle.js",
+      "!**/kpi/static/js/swagger/swagger-ui-standalone-preset.js",
+      "!**/msw-mocks/**/*"
     ]
   },
   "vcs": {
@@ -26,7 +25,7 @@
   "formatter": {
     "enabled": true, // Default.
     "formatWithErrors": false, // Default.
-    "ignore": [], // Default.
+    "includes": ["**"], // Default.
     "attributePosition": "auto", // Default.
     "indentStyle": "space", // Default is tab, we use space due imho the real standard.
     "indentWidth": 2, // Default.
@@ -47,8 +46,42 @@
       "quoteStyle": "single" // Default is double, we use single for a cleaner look.
     }
   },
-  "organizeImports": {
-    "enabled": true
+  // TODO: trying to restore the old behaviour of organizing imports:
+  // https://biomejs.dev/guides/upgrade-to-biome-v2/#the-import-organizer-sorts-the-imports-differently
+  "assist": {
+    "actions": {
+      "source": {
+        "organizeImports": {
+          "level": "on",
+          "options": {
+            "groups": [
+              // TODO adjustment to fit current code, not present in migration guide
+              "react",
+              ":BLANK_LINE:",
+
+              // Bun modules
+              ":BUN:",
+              // Node.js modules
+              ":NODE:",
+              // Modules imported with the `npm:` protocol
+              ["npm:*", "npm:*/**"],
+              // Modules imported with another protocol. e.g. `jsr:`
+              ":PACKAGE_WITH_PROTOCOL:",
+              // URLs
+              ":URL:",
+              // Libraries
+              ":PACKAGE:",
+              // Absolute paths
+              ["/**"],
+              // Sharp aliases
+              ["#*", "#*/**"],
+              // All other paths
+              ":PATH:"
+            ]
+          }
+        }
+      }
+    }
   },
   "linter": {
     "enabled": true,
@@ -59,11 +92,18 @@
         "noEmptyPattern": "off", // Recommended rule. TODO: review 5 cases and enable.
         "noInnerDeclarations": "off", // Recommended rule. TODO: review 22 cases and enable.
         "noInvalidUseBeforeDeclaration": "off", // Recommended rule. TODO: review 2 cases and enable.
+        "noNestedComponentDefinitions": "off", // Recommended rule. TODO: review 14 cases and enable.
         "noSwitchDeclarations": "off", // Recommended rule. TODO: review 2 cases and enable.
         "noUnsafeOptionalChaining": "off", // Recommended rule. TODO: review 2 cases and enable.
+        "noUnusedFunctionParameters": "off", // Recommended rule. TODO: review 28 cases and enable.
         "noUnusedImports": "error", // Enable all safely fixable rules.
+        "noUnusedVariables": "off", // Recommended rule. TODO: review 67 cases and enable.
         "useExhaustiveDependencies": "off", // Recommended rule. TODO: review 101 cases and enable.
-        "useJsxKeyInIterable": "off" // Recommended rule. TODO: review 17 cases and enable.
+        "useHookAtTopLevel": "off", // Recommended rule. TODO: review 26 cases and enable.
+        "useJsxKeyInIterable": "off", // Recommended rule. TODO: review 17 cases and enable.
+        "useParseIntRadix": "off", // Recommended rule. TODO: review 25 cases and enable.
+        "useUniqueElementIds": "off", // Recommended rule. TODO: review 15 cases and enable.
+        "useValidTypeof": "off" // Recommended rule. TODO: review 3 cases and enable.
       },
       "suspicious": {
         "noArrayIndexKey": "off", // Recommended rule. TODO: review 40 cases and enable.
@@ -78,34 +118,42 @@
         "noRedeclare": "off", // Recommended rule. TODO: review 1 case and enable.
         "noShadowRestrictedNames": "off", // Recommended rule. TODO: review 2 cases and enable.
         "useIsArray": "off", // Recommended rule. TODO: review 3 cases and enable.
-        "useValidTypeof": "off" // Recommended rule. TODO: review 3 cases and enable.
+        "useIterableCallbackReturn": "off", // Recommended rule. TODO: review 25 cases and enable.
+        "noVar": "off"
       },
       "security": {
-        "noDangerouslySetInnerHtml": "off" // Recommended rule. TODO: review 11 cases and enable.
+        "noDangerouslySetInnerHtml": "off", // Recommended rule. TODO: review 11 cases and enable.
+        "noBlankTarget": "off"
       },
       "complexity": {
         "noBannedTypes": "off", // Recommended rule. TODO: review 144 cases and enable.
         "noExtraBooleanCast": "off", // Recommended rule. TODO: review 3 cases and enable.
         "noForEach": "off", // Recommended rule. TODO: review 217 cases and enable.
         "noUselessConstructor": "off", // Recommended rule. TODO: review 1 cases and enable.
+        "noUselessEscapeInRegex": "off", // Recommended rule. TODO: review 3 cases and enable.
         "noUselessFragments": "off", // Recommended rule. TODO: review 4 cases and enable.
         "noUselessSwitchCase": "off", // Recommended rule. TODO: review 2 cases and enable.
         "noUselessTernary": "off", // Recommended rule. TODO: review 4 cases and enable.
         "noUselessUndefinedInitialization": "error", // Enable all safely fixable rules.
+        "useDateNow": "off", // Recommended rule. TODO: review 1 cases and enable.
+        "useIndexOf": "off", // Recommended rule. TODO: review 1 cases and enable.
         "useLiteralKeys": "off", // Recommended rule. TODO: review 28 cases and enable.
-        "useOptionalChain": "off" // Recommended rule. TODO: review 36 cases and enable.
+        "useOptionalChain": "off", // Recommended rule. TODO: review 36 cases and enable.
+        "noArguments": "off",
+        "noCommaOperator": "off",
+        "useWhile": "error" // Enable all safely fixable rules.
       },
       "performance": {
         "noAccumulatingSpread": "off", // Recommended rule. TODO: review 7 cases and enable.
         "noDelete": "off" // Recommended rule. TODO: review 17 cases and enable.
       },
       "a11y": {
-        "noBlankTarget": "off", // Not a problem for modern browsers; see 2021 update, see https://mathiasbynens.github.io/rel-noopener/#recommendations.
         "noLabelWithoutControl": "off", // Recommended rule. TODO: review 63 cases and enable.
         "noNoninteractiveTabindex": "off", // Recommended rule. TODO: review 1 cases and enable.
         "noPositiveTabindex": "off", // Recommended rule. TODO: review 1 cases and enable.
         "noSvgWithoutTitle": "off", // Recommended rule. TODO: review 1 cases and enable.
         "useAltText": "off", // Recommended rule. TODO: review 1 cases and enable.
+        "useAriaPropsSupportedByRole": "off", // Recommended rule. TODO: review 1 cases and enable.
         "useAriaPropsForRole": "off", // Recommended rule. TODO: review 1 cases and enable.
         "useButtonType": "off", // Recommended rule. TODO: review 31 cases and enable.
         "useFocusableInteractive": "off", // Recommended rule. TODO: review 2 cases and enable.
@@ -114,19 +162,17 @@
         "useKeyWithMouseEvents": "off", // Recommended rule. TODO: review 1 cases and enable.
         "useMediaCaption": "off", // Recommended rule. TODO: review 3 cases and enable.
         "useSemanticElements": "off", // Recommended rule. TODO: review 5 cases and enable.
+        "noStaticElementInteractions": "off", // Recommended rule. TODO: review 20 cases and enable.
         "useValidAnchor": "off" // Recommended rule. TODO: review 4 cases and enable.
       },
       "style": {
-        "noArguments": "off", // Recommended rule. TODO: review 6 cases and enable.
-        "noCommaOperator": "off", // Recommended rule. TODO: review 7 cases and enable.
         "noImplicitBoolean": "off", // Enable all safely fixable rules, except this for a cleaner look.
         "noInferrableTypes": "error", // Enable all safely fixable rules.
         "noNegationElse": "error", // Enable all safely fixable rules.
         "noNonNullAssertion": "off", // Recommended rule. TODO: review 50 cases and enable.
         "noParameterAssign": "off", // Recommended rule. TODO: review 31 cases and enable.
         "noUnusedTemplateLiteral": "off", // Recommended rule. TODO: review 5 cases and enable.
         "noUselessElse": "off", // Recommended rule. TODO: review 167 cases and enable.
-        "noVar": "off", // Recommended rule. TODO: review 234 cases and enable.
         "noYodaExpression": "error", // Enable all safely fixable rules.
         "useAsConstAssertion": "error", // Enable all safely fixable rules.
         "useCollapsedElseIf": "error", // Enable all safely fixable rules.
@@ -137,8 +183,7 @@
         "useNodejsImportProtocol": "off", // Recommended rule. TODO: review 3 cases and enable.
         "useSelfClosingElements": "error", // Enable all safely fixable rules.
         "useSingleVarDeclarator": "off", // Recommended rule. TODO: review 35 cases and enable.
-        "useTemplate": "off", // Recommended rule. TODO: review 103 cases and enable.
-        "useWhile": "error" // Enable all safely fixable rules.
+        "useTemplate": "off" // Recommended rule. TODO: review 103 cases and enable.
       }
     }
   }