Skip to content

fix(formBuilder): skip logic UI broken DEV-1215 #6429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(formBuilder): skip logic UI broken DEV-1215 #6429

wants to merge 1 commit into from

Conversation

@magicznyleszek
Copy link
Member

@magicznyleszek magicznyleszek commented Oct 30, 2025 •
edited
Loading

📣 Summary

Fixes skip logic UI appearing as multiple unusable inputs.

💭 Notes

Brings back missing select2 CSS import. 443e0db broke this.

👀 Preview steps

  1. ℹ️ have an account and a project with multiple questions
  2. Edit your project in Form Builder
  3. For the last question open "Settings" (cog icon in top right area of question row)
  4. Choose "Skip Logic" from left sidebar
  5. Use "+ ADD A CONDITION" button
  6. 🔴 [on beta] notice that question selection dropdown doesn't work and you UI is broken
  7. 🟢 [on PR] notice that you can select question and add assign some logic to it

@magicznyleszek magicznyleszek self-assigned this Oct 30, 2025
@magicznyleszek magicznyleszek marked this pull request as ready for review October 31, 2025 11:50
pauloamorimbr
pauloamorimbr approved these changes Nov 3, 2025
View reviewed changes
Copy link
Contributor

@pauloamorimbr pauloamorimbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👏🏻

GJ on finding this. Tested and it's fixed!

Akuukis
Akuukis approved these changes Nov 3, 2025
View reviewed changes
Copy link
Contributor

@Akuukis Akuukis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not tested, but it be based on release/2.025.43 ;)

@magicznyleszek magicznyleszek changed the base branch from main to release/2.025.43 November 3, 2025 12:52
@magicznyleszek magicznyleszek changed the base branch from release/2.025.43 to main November 3, 2025 12:53
@magicznyleszek
Copy link
Member Author

magicznyleszek commented Nov 3, 2025

Closing in favor of release branch one: #6438

@magicznyleszek magicznyleszek deleted the leszek/dev-1215-skip-logic-bug branch November 3, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Akuukis Akuukis Akuukis approved these changes

@pauloamorimbr pauloamorimbr pauloamorimbr approved these changes

Assignees

@magicznyleszek magicznyleszek

Labels

Front end

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@magicznyleszek @Akuukis @pauloamorimbr