fix(versions): convert version removal celery task to migration DEV-1227 #6442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…227 (#6434) ### 💭 Notes Converts the remove_all_versions celery task (which accidentally had a time limit of 30 seconds) to a long-running migration to be in keeping with the rest of the long-running works. ### 👀 Preview steps 1. Run migrations 2. If empty, populate the Version table with ``` for i in range(100): Revision.objects.create(date_created=timezone.now()) Version.objects.create(revision_id=i, content_type_id=21) ``` 3. Update `VERSION_DELETION_BATCH_SIZE` to 5 4. Restart the kpi_worker 5. Wait for the long-running migrations job to run 6. 🟢 The number of objects in the version table is decreased 7. 🟢 There are logs in the kpi_worker showing how many versions are deleted with each run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💭 Notes
Backport of #6434
Converts the remove_all_versions celery task (which accidentally had a time limit of 30 seconds) to a long-running migration to be in keeping with the rest of the long-running works.
👀 Preview steps
VERSION_DELETION_BATCH_SIZEto 5