feat(core): support generator function as command action#819
Open
Anillc wants to merge 2 commits intokoishijs:masterfrom
Open
feat(core): support generator function as command action#819Anillc wants to merge 2 commits intokoishijs:masterfrom
Anillc wants to merge 2 commits intokoishijs:masterfrom
Conversation
Codecov ReportBase: 92.25% // Head: 92.39% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #819 +/- ##
==========================================
+ Coverage 92.25% 92.39% +0.14%
==========================================
Files 60 60
Lines 6582 6605 +23
Branches 1276 1285 +9
==========================================
+ Hits 6072 6103 +31
+ Misses 510 502 -8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
shigma
changed the title
Member
|
How about RxJS observables? |
shigma
force-pushed
the
master
branch
13 times, most recently
from
a6380b3 to
d2d815c
Compare
shigma
force-pushed
the
master
branch
2 times, most recently
from
e08f6e0 to
78d105d
Compare
shigma
force-pushed
the
master
branch
5 times, most recently
from
9d729d2 to
16d5f58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
支持将 generator 传入 action 中
由于 microsoft/TypeScript#51187, 类型推断暂时并不能很好地工作
另外有待讨论的是
next中传入一个Promise<string[]>。相关 issue microsoft/TypeScript#44808由于 arrow generator 还在 stage 1, 这个用法可能还不够优雅