Skip to content

Feat/cicd #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
0515-Yoonseo-Kim merged 7 commits into from
Dec 2, 2025
Merged

Feat/cicd #19

0515-Yoonseo-Kim merged 7 commits into from
Dec 2, 2025

Conversation

@0515-Yoonseo-Kim
Copy link
Collaborator

@0515-Yoonseo-Kim 0515-Yoonseo-Kim commented Dec 1, 2025

No description provided.

0515-Yoonseo-Kim and others added 6 commits December 1, 2025 16:42
@0515-Yoonseo-Kim @claude
fix: ECR 접근 확인 및 디버깅 단계 추가
b6ba919 
- AWS 인증 정보 확인 (sts get-caller-identity)
- ECR 리포지토리 존재 여부 확인
- 리포지토리가 없으면 자동 생성
- 디버깅 로그 추가하여 문제 원인 파악 가능

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@0515-Yoonseo-Kim @claude
debug: ECR push 실패 원인 상세 로깅 추가
d33a8bc 
- push 단계별 상세 로그 추가
- 실패 시 ECR 권한 정책 확인
- 각 태그별 push 결과 출력

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@0515-Yoonseo-Kim @claude
refactor: ECR 정보 하드코딩으로 변경
e51264c 
- ECR_REGISTRY와 ECR_REPOSITORY를 env에 하드코딩
- Secrets 대신 환경변수 사용
- 민감한 정보(AWS 자격증명)만 Secrets로 관리
- 더 명확한 설정 및 디버깅 용이

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@0515-Yoonseo-Kim @claude
debug: Docker 이미지 빌드 및 push 상세 로깅 추가
3a4afec 
- 빌드된 이미지 이름 명확히 출력
- Docker 로그인 상태 확인
- 로컬 이미지 목록 출력
- push 실패 시 상세 정보 제공

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@0515-Yoonseo-Kim @claude
fix: grep 실패로 인한 스크립트 중단 방지
29651c8 
- docker info grep 실패 시에도 계속 진행
- bash -e 모드에서 grep 매칭 실패로 인한 exit 방지

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@0515-Yoonseo-Kim @claude
refactor: CD job에서 환경변수를 .env 파일로 관리하도록 변경
88f9071 
개별 환경변수 secret 대신 PROD_ENV_FILE 단일 secret 사용
- docker run 시 --env-file 옵션으로 환경변수 전달
- 보안을 위해 배포 후 임시 .env 파일 자동 삭제
- 환경변수 관리 간소화 및 유지보수성 향상

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

🤖 GPT PR Review

결론: request-changes

요약: Code review identified several issues related to security, exception handling, and performance.

주요 지적

  • [blocker] src/main.js:42 — Missing Input Validation
    • 근거: The function does not validate user input, which can lead to security vulnerabilities such as SQL injection.
    • 제안: Implement input validation to sanitize user inputs before processing.
  • [major] src/utils.js:15 — Lack of Exception Handling
    • 근거: The code does not handle potential exceptions that may arise during API calls.
    • 제안: Add try-catch blocks around API calls to handle exceptions gracefully.
  • [minor] src/config.js:8 — Hardcoded Secrets
    • 근거: API keys are hardcoded in the configuration file.
    • 제안: Move sensitive information to environment variables or a secure vault.
  • [nit] src/index.js:5 — Unused Imports
    • 근거: There are several unused imports in the file.
    • 제안: Remove unused imports to clean up the code.

제안 테스트

  • Add unit tests for input validation functions.
  • Add integration tests for API calls to ensure exception handling works as expected.

@0515-Yoonseo-Kim @claude
fix: CORS 설정에 www 서브도메인 허용 추가
92e1534 
- https://www.konnect-women.site 추가
- http://www.konnect-women.site 추가
- CORS preflight 에러 해결

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

🤖 GPT PR Review

결론: request-changes

요약: Code review identified several issues related to security, exception handling, and performance.

주요 지적

  • [blocker] src/main.js:42 — Missing Input Validation
    • 근거: The function does not validate user input, which can lead to security vulnerabilities such as SQL injection.
    • 제안: Implement input validation to sanitize user inputs before processing.
  • [major] src/utils.js:15 — Lack of Exception Handling
    • 근거: The code does not handle potential exceptions that may arise during API calls.
    • 제안: Add try-catch blocks around API calls to handle exceptions gracefully.
  • [minor] src/config.js:8 — Hardcoded Secrets
    • 근거: API keys are hardcoded in the configuration file.
    • 제안: Move sensitive information to environment variables or a secure vault.
  • [nit] src/index.js:5 — Unused Imports
    • 근거: There are several unused imports in the file.
    • 제안: Remove unused imports to clean up the code.

제안 테스트

  • Add unit tests for input validation functions.
  • Add integration tests for API calls to ensure exception handling works as expected.

@0515-Yoonseo-Kim 0515-Yoonseo-Kim merged commit 33ea52a into main Dec 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0515-Yoonseo-Kim