Adding system certs support for Mac and Linux - #2364
Merged
Conversation
cesarfda
changed the title
RebeccaMahany
previously approved these changes
Jul 17, 2025
zackattack01
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
InstallCaCertsfunction inpkg/osquery/install_ca_certs.goto prioritize using system CA certificates over the embedded bundle, improving flexibility and compatibility across different operating systems. It also introduces a helper function,getSystemCaCertPath, to determine the appropriate system CA certificate path based on the operating system.Refactoring of
InstallCaCertsfunction:InstallCaCertsto prefer system CA certificates over the embedded bundle, improving compatibility with native environments. If system certificates are not available, it falls back to installing the embedded bundle.Addition of
getSystemCaCertPathhelper function:getSystemCaCertPathto determine the system CA certificate path based on the operating system (runtime.GOOS). It supports Linux and macOS with predefined paths and returns an error for unsupported operating systems.