fix(remotectl): fix four bugs in parser - #2681
Draft
directionless wants to merge 1 commit into
Draft
Conversation
extractKeyValue used strings.Split so values containing the delimiter (e.g. URLs with colons) triggered an error and dropped the device. parseObjectArray accessed arrayResults[len-1] without a bounds check, panicking when a property-level line appeared before any item. getCurrentIndentationLevel used strings.LastIndex instead of counting leading tabs, misreporting the nesting depth when values contained tabs. parseDumpstate unconditionally advanced the scanner after each parseDevice call; when a sub-parser consumed the next device name as its exit condition, the first property of that device was silently dropped. - extractKeyValue: use SplitN(..., 2) to preserve delimiters in values - parseObjectArray: guard against empty arrayResults before index access - getCurrentIndentationLevel: count leading tabs with a loop - parseDumpstate: reuse p.lastReadLine when it already holds a device name instead of always advancing the scanner Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extractKeyValue used strings.Split so values containing the delimiter (e.g. URLs with colons) triggered an error and dropped the device. parseObjectArray accessed arrayResults[len-1] without a bounds check, panicking when a property-level line appeared before any item. getCurrentIndentationLevel used strings.LastIndex instead of counting leading tabs, misreporting the nesting depth when values contained tabs. parseDumpstate unconditionally advanced the scanner after each parseDevice call; when a sub-parser consumed the next device name as its exit condition, the first property of that device was silently dropped.