Guard against missing name/query keys in scheduled query results - #2691
Open
directionless wants to merge 1 commit into
Open
Guard against missing name/query keys in scheduled query results#2691directionless wants to merge 1 commit into
directionless wants to merge 1 commit into
Conversation
directionless
force-pushed
the
claude/fix-localserver-map-keys
branch
from
April 13, 2026 18:55
0322229 to
50dad86
Compare
Contributor
Author
|
This feels a little excessive, but I think, not wrong. Perhaps there's some narrow case it the |
directionless
marked this pull request as ready for review
April 14, 2026 11:40
| "scheduled query result missing name or query field", | ||
| "query_name", name, | ||
| ) | ||
| results[i].Status = 1 |
Contributor
There was a problem hiding this comment.
Is there a const we can use for this? Maybe osquery-go's ExtensionCode_EXT_FAILED?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
osquery_schedule rows are map[string]string; accessing a missing key returns empty string rather than panicking, but passing an empty string as a SQL query to the querier would cause a confusing error. Add explicit presence and emptiness checks before using each value.