Remove obsolete launcher tables and fix Mach-O parsing - #2788
Merged
Conversation
Stop advertising vestigial Google Drive and Spotlight capabilities, and support universal Mach-O binaries while documenting table reliability checks.
Keep this branch focused on the runtime table cleanup and Mach-O fix.
RebeccaMahany
left a comment
RebeccaMahany
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the cleanup!
| macos_software_update.MacOSUpdate(k, slogger), | ||
| macos_software_update.RecommendedUpdates(k, slogger), | ||
| MachoInfo(k, slogger), | ||
| spotlight.TablePlugin(k, slogger), |
Contributor
There was a problem hiding this comment.
Did you confirm that these tables aren't in use in any custom checks?
Contributor
Author
There was a problem hiding this comment.
I'll wait on confirmation here: https://kolide.slack.com/archives/CJ3Q1QAJJ/p1786374680528949
Contributor
There was a problem hiding this comment.
Heh, I came here to say the same thing. I think we were using it within the last couple years. Which of this or the osquery one works better seems to swap every couple years.
Normalize path separators so the cross-platform table tests and app-name extraction behave consistently.
Drop the legacy SQLite-backed table so it is no longer registered or published in the launcher schema.
Drop the launcher implementation now that the KATC replacement is available, and preserve the package-wide leak test harness.
Drop the remaining legacy Chrome saved-login implementation now that the KATC replacement is available.
Keep the distinct keychain table registered while removing only the superseded Chrome login email aggregation.
RebeccaMahany
previously approved these changes
Aug 11, 2026
Restore these tables here so their removal can be reviewed independently under KOL-1178.
Contributor
Author
|
https://github.com/kolide/k2/pull/15061 merged so we should be unblocked to merge this pr |
RebeccaMahany
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kolide_chrome_login_keychaintable registeredDependencies
kolide_chrome_login_data_emailstokatc_chrome_login_data_emails; merge that PR firstFollow-ups
kolide_spotlightandkolide_onepassword_accountsmoved to launcher#2791, linked to KOL-1178kolide_slack_configfor now because it is still in useTest plan
go test ./cmd/launcher ./pkg/osquery/table -count=1make lint/bin/lsthroughkolide_macho_infoRelated