Prevent signal panic on race during immediate shutdown - #2803
Merged
Conversation
RebeccaMahany
marked this pull request as ready for review
August 25, 2026 19:49
zackattack01
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #2787. I think there's a second panic condition if launcher starts up and then shuts down basically immediately,
Interruptcan race withExecuteand the channel can close beforeExecutecallssignal.Notify(sigChannel, os.Interrupt, syscall.SIGTERM). So I movedsignal.Notify(sigChannel, os.Interrupt, syscall.SIGTERM)intonewSignalListenerso it's guaranteed to run first. I also added a separateinterruptchannel so that we don't have to closesigChanneleither.