osquery/runtime: fix osqueryinstance's WithStartFunc - #2806
Open
brhoades wants to merge 1 commit into
Open
Conversation
I stared at this for over a full work day and only just now caught it. This is one of the reasons TestRestart flakes often... we discard the startFunc that should delay starting.
brhoades
marked this pull request as ready for review
August 28, 2026 21:28
brhoades
enabled auto-merge
August 28, 2026 21:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WithStartFunc doesn't work. We always clobber it with a default. It's only used by tests.
I have stared at this file, neck deep in a refactor, for over a day. I don't know if this had a negative effect on the sole test that used it,
TestOsquerySlowStart, since it passed. It clearly couldn't do what it was trying to.It upset me when I finally saw it, so it's worth fixing 👍.