chore(KFLUXVNGD-155): Add custom certificate support for git clone task #1814
+141
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmariset
force-pushed
the
KFLUXVNGD-155
branch
5 times, most recently
from
69d2738 to
e4568e5
Compare
hmariset
changed the title
hmariset
force-pushed
the
KFLUXVNGD-155
branch
5 times, most recently
from
9cdc9b9 to
57840dd
Compare
yftacherzog
reviewed
Jan 20, 2025
| @@ -159,6 +159,12 @@ func perform(task *pipeline.Task, recipe *Recipe) error { | |||
| Name: "workdir", | |||
| MountPath: "/var/workdir", | |||
| } | |||
| trustedVolumeMount := core.VolumeMount{ | |||
| Name: "trusted-ca", | |||
There was a problem hiding this comment.
I'm not sure we should hard code the name of the volume. Maybe we can have trusted-ca as the default, and include an optional recipe field for specifying a different volume name.
Same goes for the sub-path. The volume might have the certificate stored under a different path.
I think we also need to have it documented.
Add param to support the custom certificate support for git-clone-oci-ta task to connect to internal registry. Jira-Url: https://issues.redhat.com/browse/KFLUXVNGD-155 Signed-off-by: Homaja Marisetty <[email protected]>
hmariset
force-pushed
the
KFLUXVNGD-155
branch
from
57840dd to
8ab3727
Compare
hmariset
requested review from
ralphbean,
ligangty,
yma96,
cgwalters,
kdudka,
a team,
brunoapimentel,
eskultety and
taylormadore
as code owners
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add param to support the custom certificate support for git-clone-oci-ta task to connect to internal registry.
Jira-Url: https://issues.redhat.com/browse/KFLUXVNGD-155