source-build, deprecated-image-check: support reading base images from SPDX SBOMs #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support extracting the base image from both CycloneDX SBOMs and SPDX
SBOMs.
In an SPDX SBOM, the base/builder images are identified via JSON-encoded
annotations. Example:
{
"SPDXID": "SPDXRef-image-...
"name": "registry.access.redhat.com/ubi9/ubi-micro",
"downloadLocation": "NOASSERTION",
"externalRefs": [
{
"referenceCategory": "PACKAGE-MANAGER",
"referenceType": "purl",
"referenceLocator": "pkg:oci/ubi-micro@sha256:...?repository_url=..."
}
],
"annotations": [
{
"annotator": "Tool: konflux:jsonencoded",
"comment": "{\"name\":\"konflux:container:is_base_image\",\"value\":\"true\"}",
"annotationDate": "2025-01-13T12:15:31Z",
"annotationType": "OTHER"
}
]
}
Signed-off-by: Adam Cmiel <[email protected]>
Support extracting the base/builder images from both CycloneDX SBOMs
and SPDX SBOMs.
In an SPDX SBOM, the base/builder images are identified via JSON-encoded
annotations. Example:
{
"SPDXID": "SPDXRef-image-...
"name": "registry.access.redhat.com/ubi9/ubi-micro",
"downloadLocation": "NOASSERTION",
"externalRefs": [
{
"referenceCategory": "PACKAGE-MANAGER",
"referenceType": "purl",
"referenceLocator": "pkg:oci/ubi-micro@sha256:...?repository_url=..."
}
],
"annotations": [
{
"annotator": "Tool: konflux:jsonencoded",
"comment": "{\"name\":\"konflux:container:is_base_image\",\"value\":\"true\"}",
"annotationDate": "2025-01-13T12:15:31Z",
"annotationType": "OTHER"
}
]
}
Signed-off-by: Adam Cmiel <[email protected]>
chmeliik
force-pushed
the
base-images-from-spdx
branch
from
d8ba4df to
2a4ed4f
Compare
|
Added example of SPDX base image format to commit messages |
mkosiarc
approved these changes
Jan 15, 2025
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support extracting the base/builder images from both CycloneDX SBOMs
and SPDX SBOMs.
Tested in redhat-appstudio/rh-syft#105
source-build:
deprecated-image-check: