Skip to content

Conversation

hmariset
Copy link
Contributor

@hmariset hmariset commented Aug 7, 2025

Update the squid-exporter Containerfile to consolidate into squid container image.

Jira-Url: https://issues.redhat.com/browse/KFLUXVNGD-434

Assisted-by: Cursor

@hmariset hmariset requested a review from a team as a code owner August 7, 2025 17:14
@hmariset hmariset force-pushed the update-exporter-containerfile branch from 88fe8c1 to b4a42c1 Compare August 7, 2025 17:18
@hmariset hmariset marked this pull request as draft August 7, 2025 17:21
@hmariset
Copy link
Contributor Author

hmariset commented Aug 7, 2025

Converting to draft since it depends on PR - konflux-ci/squid-exporter#1 which needs to be merged first

@hmariset hmariset force-pushed the update-exporter-containerfile branch 3 times, most recently from 0840467 to 5caa56c Compare August 7, 2025 21:07
Copy link
Member

@ifireball ifireball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to also remove the Mage tasks that still try to build the old exported Containerfile.

@hmariset hmariset force-pushed the update-exporter-containerfile branch 2 times, most recently from ee59c7d to 2e0c856 Compare August 12, 2025 14:38
@hmariset hmariset marked this pull request as ready for review August 12, 2025 15:01
@hmariset hmariset force-pushed the update-exporter-containerfile branch from 2e0c856 to 128f24a Compare August 12, 2025 15:15
@hmariset hmariset requested a review from ifireball August 13, 2025 02:41
@hmariset hmariset force-pushed the update-exporter-containerfile branch 2 times, most recently from 7f20ad6 to e202b00 Compare August 13, 2025 13:55
@hmariset
Copy link
Contributor Author

@ifireball Updated the Containerfile to use upstream repo. Please review again.

@hmariset hmariset requested a review from amisstea August 13, 2025 15:33
@hmariset hmariset force-pushed the update-exporter-containerfile branch 5 times, most recently from 7644266 to ae91a58 Compare August 14, 2025 01:46
@hmariset hmariset force-pushed the update-exporter-containerfile branch 6 times, most recently from 5296feb to 1d36e36 Compare August 14, 2025 13:55
@hmariset
Copy link
Contributor Author

/retest

1 similar comment
@hmariset
Copy link
Contributor Author

/retest

@hmariset hmariset force-pushed the update-exporter-containerfile branch 7 times, most recently from d62a87a to 12b2442 Compare August 14, 2025 18:44
@hmariset hmariset requested a review from amisstea August 14, 2025 19:00
@hmariset hmariset force-pushed the update-exporter-containerfile branch from 12b2442 to 1f0abb1 Compare August 14, 2025 19:11
@hmariset hmariset force-pushed the update-exporter-containerfile branch 2 times, most recently from dfbe70f to 3c6ede0 Compare August 14, 2025 20:43
Update the squid-exporter Containerfile to consolidate into
squid container image.

Jira-Url: https://issues.redhat.com/browse/KFLUXVNGD-434
Signed-off-by: Homaja Marisetty <[email protected]>
Assisted-by: Cursor
@hmariset hmariset force-pushed the update-exporter-containerfile branch from 3c6ede0 to e4ff8de Compare August 14, 2025 21:08
@hmariset hmariset enabled auto-merge August 14, 2025 21:42
@hmariset hmariset dismissed ifireball’s stale review August 14, 2025 21:45

Barak is in PTO for next 15 days

@hmariset hmariset added this pull request to the merge queue Aug 14, 2025
Merged via the queue into konflux-ci:main with commit 5aba31b Aug 14, 2025
7 checks passed
@hmariset hmariset deleted the update-exporter-containerfile branch August 14, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants