Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add golangci-lint and Gosec Security Scanner GH workflows, and remove build.yml #11

Merged
merged 3 commits into from
Feb 9, 2024
Merged

feat: add golangci-lint and Gosec Security Scanner GH workflows, and remove build.yml #11

merged 3 commits into from
Feb 9, 2024

Conversation

dheerajodha
Copy link
Member

No description provided.

@dheerajodha dheerajodha force-pushed the add-lint-and-security-workflows branch from 1902d50 to 3002506 Compare February 2, 2024 11:10
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@dheerajodha dheerajodha requested a review from psturc February 2, 2024 11:11
@dheerajodha dheerajodha force-pushed the add-lint-and-security-workflows branch from 3002506 to 53d81c6 Compare February 2, 2024 11:25
@dheerajodha dheerajodha changed the title feat: add golangci-lint and Gosec Security Scanner GH workflows feat: add golangci-lint and Gosec Security Scanner GH workflows, and remove build.yml Feb 2, 2024
@dheerajodha
Copy link
Member Author

For context: We need to remove build.yml because as part of KONFLUX-2071, we made some significant updates to the codebase and we no longer want to use Godel binary (which is used by build.yml file, as evident from the failures like this).

@psturc psturc merged commit 01e6f69 into main Feb 9, 2024
5 checks passed
psturc pushed a commit that referenced this pull request Apr 17, 2024
@dheerajodha @psturc
feat: add golangci-lint and Gosec Security Scanner GH workflows, and …
49476db 
…remove build.yml (#11)

* feat: add new linter and security-related GH workflows

Signed-off-by: Dheeraj<[email protected]>

* fix: remove the use of a deprecated package to address go-lint error

signed-off-by: Dheeraj<[email protected]>

* fix: delete build.yml file since it uses godel (we dont use it anymore)

Signed-off-by: Dheeraj<[email protected]>

---------

Signed-off-by: Dheeraj<[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psturc psturc psturc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dheerajodha @psturc